fix(compiler): use resolveModuleNames TypeScript API to get resolved modules for test files#1784
Merged
ahnpnl merged 2 commits intokulshekhar:masterfrom Jul 8, 2020
ahnpnl:type-checking
Merged
fix(compiler): use resolveModuleNames TypeScript API to get resolved modules for test files#1784ahnpnl merged 2 commits intokulshekhar:masterfrom ahnpnl:type-checking
ahnpnl merged 2 commits intokulshekhar:masterfrom
ahnpnl:type-checking
Conversation
ahnpnl
changed the title
Pull Request Test Coverage Report for Build 5295
💛 - Coveralls |
kulshekhar
previously approved these changes
Jul 7, 2020
Collaborator
Author
|
sorry I was trying to improve unit tests for the async |
Collaborator
Author
|
did a final push, noticed a debug log was wrong 😃 |
kulshekhar
approved these changes
Jul 8, 2020
This was referenced Jul 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove workaround in
compiler-utils.tsand replace withresolveModuleNamesfromLanguageServiceAPI.Fixes #1747
Test plan
Added unit tests. Green CI
Does this PR introduce a breaking change?
Other information
N.A.